WeiZhong94 commented on a change in pull request #10017: [FLINK-14019][python] 
add support for managing environment and dependencies of Python UDF in Flink 
Python API
URL: https://github.com/apache/flink/pull/10017#discussion_r350518034
 
 

 ##########
 File path: flink-python/pyflink/table/table_environment.py
 ##########
 @@ -883,8 +987,8 @@ def __init__(self, j_tenv, is_blink_planner):
         self._j_tenv = j_tenv
         super(StreamTableEnvironment, self).__init__(j_tenv, is_blink_planner)
 
-    def _get_execution_config(self, filename, schema):
 
 Review comment:
   Dependency manager needs execution environment to register files, so we need 
to implement a "_get_j_env" method to get it, which can completely replace this 
method. The old implementation also has a few problem and it's a internal 
method, so I removed it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to