WeiZhong94 commented on a change in pull request #10017: [FLINK-14019][python]
add support for managing environment and dependencies of Python UDF in Flink
Python API
URL: https://github.com/apache/flink/pull/10017#discussion_r349062753
##########
File path:
flink-python/src/main/java/org/apache/flink/table/runtime/operators/python/PythonScalarFunctionOperator.java
##########
@@ -106,15 +107,16 @@ public void emitResults() {
}
@Override
- public PythonFunctionRunner<Row>
createPythonFunctionRunner(FnDataReceiver<Row> resultReceiver) {
+ public PythonFunctionRunner<Row> createPythonFunctionRunner(
+ FnDataReceiver<Row> resultReceiver,
+ PythonEnvironmentManager pythonEnvironmentManager) {
Review comment:
PythonEnvironmentManager is created from the information provided by
AbstractPythonFunctionOperator and used in PythonFunctionRunner so maybe it is
not a best choice that let it become a field of AbstractPythonFunctionOperator.
But we can still remove it from here to keep the interface unchanged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
