TisonKun commented on a change in pull request #10313: [FLINK-14840] Use
Executor interface in SQL cli
URL: https://github.com/apache/flink/pull/10313#discussion_r350563329
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/result/MaterializedCollectBatchResult.java
##########
@@ -78,8 +82,9 @@ public boolean isMaterialized() {
@Override
public void startRetrieval(ProgramDeployer<C> deployer) {
- this.deployer = deployer;
- retrievalThread.start();
+ deployer.run()
+ .thenCompose(jobClient ->
jobClient.getJobExecutionResult(classLoader))
Review comment:
close job client on return I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
