TisonKun commented on a change in pull request #10313: [FLINK-14840] Use
Executor interface in SQL cli
URL: https://github.com/apache/flink/pull/10313#discussion_r350558703
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/ProgramTargetDescriptor.java
##########
@@ -25,56 +25,28 @@
*/
public class ProgramTargetDescriptor {
- private final String clusterId;
-
private final String jobId;
- private final String webInterfaceUrl;
-
- public ProgramTargetDescriptor(String clusterId, String jobId, String
webInterfaceUrl) {
- this.clusterId = clusterId;
+ public ProgramTargetDescriptor(String jobId) {
this.jobId = jobId;
- this.webInterfaceUrl = webInterfaceUrl;
- }
-
- public String getClusterId() {
- return clusterId;
}
public String getJobId() {
Review comment:
Maybe out of this patch but any reason we stick to `String` representation
of `JobID`? I've checked the usage and it seems we can just use `JobID` type
and print its hex string representation in `toString` method. The idea is that
a concrete type is better than generic `String` representation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
