lirui-apache commented on issue #8859: [FLINK-12905][table-planner] Enable querying CatalogViews in legacy planner URL: https://github.com/apache/flink/pull/8859#issuecomment-558504806 @dawidwys Thanks for the update. +1 to have self contained dialect flag in view definition. The PR looks good to me overall. Just left some minor comment. I agree with @danny0405 we need to support views via DDL, which can be done as follow ups. My understanding is this PR only enables the planner to handle CatalogViews. But we shouldn't expect end users to directly create CatalogView instances because users wouldn't know how to generate expanded query strings, right?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
