walterddr commented on a change in pull request #10193: [FLINK-13938][yarn] Use
pre-uploaded flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r351047333
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
##########
@@ -263,6 +298,36 @@ private static LocalResource
registerLocalResource(FileSystem fs, Path remoteRsr
return localResource;
}
+ /**
+ * Register a local resource with resource info. The resource info may
contains multiple parts.
+ * For example,
RemotePath;[resourceSize;resourceModificationTime;LocalResourceVisibility]
+ * @param resourceInfoStr resource info string
+ * @param yarnConfig yarn configuration
+ * @return local resource tuple, f0 is filename, f1 is local resource.
+ */
+ private static Tuple2<String, LocalResource> registerLocalResource(
Review comment:
@TisonKun correct me if I were wrong. I think you are also having concerns
regarding the branch out paradigm here
Reiterating my previous comment: since the code path to deal with
preuploaded resource is different from the local resource (given the if-else
pattern) we can probably split it into different methods? what do you think
@TisonKun @wangyang0918
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
