walterddr commented on a change in pull request #10193: [FLINK-13938][yarn] Use
pre-uploaded flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r349743614
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
##########
@@ -129,6 +134,33 @@ public static void setupYarnClassPath(Configuration conf,
Map<String, String> ap
}
}
+ /**
+ * Setup and register a pre-uploaded resource according to the file
status.
+ *
+ * @param localSrcPath
+ * path to the local file
+ * relative target path of the file (will be prefixed be
the full home directory we set up)
+ * @param preUploadedFileStatus
+ * the corresponding pre-uploaded file status of localSrcPath
+ *
+ * @return Path to remote file (usually hdfs)
+ */
+ static Tuple2<Path, LocalResource> setupPreUploadedResource(
Review comment:
@TisonKun I am not sure if there's a follow up JIRA created yet for PR
#10187 ? are you planning to use similar approach like this one to support a
remote URL resource (like Jars)? if yes I think this is fine, otherwise
`setUpYarnPublicCacheResource` might be more accurate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
