kl0u commented on a change in pull request #10311: [FLINK-14762][client] Enrich
JobClient API
URL: https://github.com/apache/flink/pull/10311#discussion_r351137039
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
##########
@@ -323,11 +318,14 @@ public void close() {
});
return submissionFuture
- .thenApply(
- (JobSubmitResponseBody jobSubmitResponseBody)
-> new JobSubmissionResult(jobGraph.getJobID()))
+ .thenApply(ignore -> new
ClusterClientJobClientAdapter<>(this, jobGraph.getJobID()))
.exceptionally(
- (Throwable throwable) -> {
- throw new CompletionException(new
JobSubmissionException(jobGraph.getJobID(), "Failed to submit JobGraph.",
ExceptionUtils.stripCompletionException(throwable)));
+ t -> {
+ throw new CompletionException(
Review comment:
It seems that this is only a code style refactoring with no changes. I would
revert this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
