kl0u commented on a change in pull request #10311: [FLINK-14762][client] Enrich
JobClient API
URL: https://github.com/apache/flink/pull/10311#discussion_r351679227
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobStatus.java
##########
@@ -97,6 +100,26 @@ public boolean isGloballyTerminalState() {
public boolean isTerminalState() {
return terminalState != TerminalState.NON_TERMINAL;
}
+
+ private static Map<JobStatus, org.apache.flink.api.common.JobStatus> m;
+
+ static {
+ m = new HashMap<>();
+ m.put(CREATED, org.apache.flink.api.common.JobStatus.CREATED);
+ m.put(RUNNING, org.apache.flink.api.common.JobStatus.RUNNING);
+ m.put(FAILING, org.apache.flink.api.common.JobStatus.FAILING);
+ m.put(FAILED, org.apache.flink.api.common.JobStatus.FAILED);
+ m.put(CANCELLING,
org.apache.flink.api.common.JobStatus.CANCELLING);
+ m.put(CANCELED, org.apache.flink.api.common.JobStatus.CANCELED);
+ m.put(FINISHED, org.apache.flink.api.common.JobStatus.FINISHED);
+ m.put(RESTARTING,
org.apache.flink.api.common.JobStatus.RESTARTING);
+ m.put(SUSPENDED,
org.apache.flink.api.common.JobStatus.SUSPENDED);
+ m.put(RECONCILING,
org.apache.flink.api.common.JobStatus.RECONCILING);
+ }
Review comment:
I would make it an unmodifiable map:
```
private static final Map<JobStatus, org.apache.flink.api.common.JobStatus> m;
static {
final Map<JobStatus, org.apache.flink.api.common.JobStatus> mm
= new HashMap<>();
mm.put(CREATED, org.apache.flink.api.common.JobStatus.CREATED);
mm.put(RUNNING, org.apache.flink.api.common.JobStatus.RUNNING);
mm.put(FAILING, org.apache.flink.api.common.JobStatus.FAILING);
mm.put(FAILED, org.apache.flink.api.common.JobStatus.FAILED);
mm.put(CANCELLING,
org.apache.flink.api.common.JobStatus.CANCELLING);
mm.put(CANCELED,
org.apache.flink.api.common.JobStatus.CANCELED);
mm.put(FINISHED,
org.apache.flink.api.common.JobStatus.FINISHED);
mm.put(RESTARTING,
org.apache.flink.api.common.JobStatus.RESTARTING);
mm.put(SUSPENDED,
org.apache.flink.api.common.JobStatus.SUSPENDED);
mm.put(RECONCILING,
org.apache.flink.api.common.JobStatus.RECONCILING);
m = Collections.unmodifiableMap(mm);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
