TisonKun commented on a change in pull request #10313: [FLINK-14840] Use
Executor interface in SQL cli
URL: https://github.com/apache/flink/pull/10313#discussion_r351291542
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
##########
@@ -523,12 +525,12 @@ public void stop(SessionContext session) {
}
// store the result with a unique id (the job id for now)
- final String resultId = jobGraph.getJobID().toString();
Review comment:
Except this comment my concerns are covered by your follow-ups @aljoscha ,
thanks for your working!
I don't run this patch with a handy test since never I use SQL client
myself. I expect Timo will give a final look so become a bit lazy :P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
