rkhachatryan commented on a change in pull request #10345: 
[FLINK-12484][runtime] synchronize all mailbox actions
URL: https://github.com/apache/flink/pull/10345#discussion_r351804282
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -384,57 +386,59 @@ protected Counter 
setupNumRecordsInCounter(StreamOperator streamOperator) {
                }
        }
 
-       @Override
-       public final void invoke() throws Exception {
+       private void beforeInvoke() throws Exception {
 
 Review comment:
   This would require changes to most of the StreamTask descendants, which are 
completely unrelated to the current task. I'd rather keep the scope of changes 
limited.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to