rkhachatryan commented on a change in pull request #10345:
[FLINK-12484][runtime] synchronize all mailbox actions
URL: https://github.com/apache/flink/pull/10345#discussion_r351914910
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -262,7 +262,7 @@ protected StreamTask(
this.accumulatorMap =
getEnvironment().getAccumulatorRegistry().getUserMap();
this.recordWriter = createRecordWriterDelegate(configuration,
environment);
this.executionDecorator =
Preconditions.checkNotNull(executionDecorator);
- this.mailboxProcessor = new
MailboxProcessor(this::processInput);
+ this.mailboxProcessor = new
MailboxProcessor(this::processInput, this.executionDecorator);
Review comment:
Inlining `invokeProcessingTimeCallback` and removing sync inside.
As of `performCheckpoint()`, I don't think it's safe, because it's
accessible via public methods. I think we should check the difference in
benchmarks first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
