pnowojski commented on a change in pull request #10345: [FLINK-12484][runtime]
synchronize all mailbox actions
URL: https://github.com/apache/flink/pull/10345#discussion_r351861349
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -262,7 +262,7 @@ protected StreamTask(
this.accumulatorMap =
getEnvironment().getAccumulatorRegistry().getUserMap();
this.recordWriter = createRecordWriterDelegate(configuration,
environment);
this.executionDecorator =
Preconditions.checkNotNull(executionDecorator);
- this.mailboxProcessor = new
MailboxProcessor(this::processInput);
+ this.mailboxProcessor = new
MailboxProcessor(this::processInput, this.executionDecorator);
Review comment:
With this, checkpointing and processing time timers actions are acquiring
checkpoint lock twice. I think `invokeProcessingTimeCallback` and
`performCheckpoint` should stop using the decorator explicitly?
(`triggerCheckpointOnBarrier` should probably still use it)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
