pnowojski commented on a change in pull request #10345: [FLINK-12484][runtime]
synchronize all mailbox actions
URL: https://github.com/apache/flink/pull/10345#discussion_r351821224
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -201,6 +201,8 @@
/** Flag to mark this task as canceled. */
Review comment:
Yes, this should be something like `[hotifx][runtime,task] Split
StreamTask#invoke into a smaller methods`.
More detailed explanation/motivation in the commit message is always
welcomed, but here I would struggle to suggest something that's not in your
face obvious like "Because the method is too big", which doesn't add much value
;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
