lirui-apache commented on a change in pull request #10325: [FLINK-14512][table]
Introduce listPartitionsByFilter to Catalog
URL: https://github.com/apache/flink/pull/10325#discussion_r352441337
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/Catalog.java
##########
@@ -288,6 +289,20 @@ void alterTable(ObjectPath tablePath, CatalogBaseTable
newTable, boolean ignoreI
List<CatalogPartitionSpec> listPartitions(ObjectPath tablePath,
CatalogPartitionSpec partitionSpec)
throws TableNotExistException, TableNotPartitionedException,
CatalogException;
+ /**
+ * Get CatalogPartitionSpec of all partitions that is under the given
CatalogPartitionSpec in the table.
+ *
+ * @param tablePath path of the table
+ * @param filters filters to push down filter to catalog
+ * @return a list of CatalogPartitionSpec that is under the given
CatalogPartitionSpec in the table
+ *
+ * @throws TableNotExistException thrown if the table does not exist in
the catalog
+ * @throws TableNotPartitionedException thrown if the table is not
partitioned
+ * @throws CatalogException in case of any runtime exception
+ */
+ List<CatalogPartitionSpec> listPartitionsByFilter(ObjectPath tablePath,
List<Expression> filters)
Review comment:
For `FieldReferenceExpression`, is the field index based on partition
columns only, or all columns? Let's define that in the API so that implementing
classes know how to handle it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
