lirui-apache commented on a change in pull request #10325: [FLINK-14512][table] 
Introduce listPartitionsByFilter to Catalog
URL: https://github.com/apache/flink/pull/10325#discussion_r352439856
 
 

 ##########
 File path: 
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/Catalog.java
 ##########
 @@ -288,6 +289,20 @@ void alterTable(ObjectPath tablePath, CatalogBaseTable 
newTable, boolean ignoreI
        List<CatalogPartitionSpec> listPartitions(ObjectPath tablePath, 
CatalogPartitionSpec partitionSpec)
                throws TableNotExistException, TableNotPartitionedException, 
CatalogException;
 
+       /**
+        * Get CatalogPartitionSpec of all partitions that is under the given 
CatalogPartitionSpec in the table.
+        *
+        * @param tablePath     path of the table
+        * @param filters filters to push down filter to catalog
+        * @return a list of CatalogPartitionSpec that is under the given 
CatalogPartitionSpec in the table
 
 Review comment:
   ```suggestion
         * @return a list of CatalogPartitionSpec that satisfy the filter 
expressions
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to