pnowojski commented on a change in pull request #10345: [FLINK-12484][runtime]
synchronize all mailbox actions
URL: https://github.com/apache/flink/pull/10345#discussion_r352489099
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -909,11 +918,12 @@ private void notifyCheckpointComplete(long checkpointId)
{
operator.notifyCheckpointComplete(checkpointId);
}
}
- success = true;
+ return true;
} else {
LOG.debug("Ignoring notification of
complete checkpoint for not-running task {}", getName());
+ return true;
}
- }
+ });
Review comment:
this commit (2nd) hasn't modified the `invokeProcessingTimeCallback` which
makes it a bit inconsistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
