pnowojski commented on a change in pull request #10345: [FLINK-12484][runtime] 
synchronize all mailbox actions
URL: https://github.com/apache/flink/pull/10345#discussion_r352504099
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java
 ##########
 @@ -28,13 +28,10 @@
 
 
 Review comment:
   Commit message could be more descriptive. 
   > Do not expose Mail#runnable field
   as this is not encapsulating the field?
   
   Also this should be a `hotfix` commit, not part of the FLINK-12484 issue? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to