xintongsong commented on a change in pull request #10146: 
[FLINK-14188][runtime] TaskExecutor derive and register with default slot 
resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r352561395
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtils.java
 ##########
 @@ -593,9 +600,20 @@ private static void sanityCheckShuffleMemory(final 
Configuration config, final M
                }
        }
 
+       @Nullable
+       private static CPUResource getCpuCores(final Configuration config) {
+               double cpuCores = 
config.getDouble(TaskManagerOptions.CPU_CORES);
+               if (cpuCores >= 0.0) {
+                       return new CPUResource(cpuCores);
+               } else {
+                       return null;
 
 Review comment:
   See above.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to