xintongsong commented on a change in pull request #10146:
[FLINK-14188][runtime] TaskExecutor derive and register with default slot
resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r352562818
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtilsTest.java
##########
@@ -556,6 +559,82 @@ public void testConfigTotalProcessMemoryAddUpFailure() {
validateFail(conf);
}
+ @Test
+ public void testConfigDefaultSlotFraction() {
+ final double defaultSlotFraction = 0.5;
+
+ Configuration conf = new Configuration();
+ conf.setDouble(TaskManagerOptions.DEFAULT_SLOT_FRACTION,
(float) defaultSlotFraction);
+
+ validateInAllConfigurations(conf, taskExecutorResourceSpec -> {
Review comment:
As discussed offline, I'll deduplicate the validation codes in the two test
cases with a private method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
