zhuzhurk commented on a change in pull request #9965: [FLINK-10935][kubernetes]Implement KubeClient with Faric8 Kubernetes clients URL: https://github.com/apache/flink/pull/9965#discussion_r352973364
########## File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesUtilsTest.java ########## @@ -0,0 +1,272 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.CoreOptions; +import org.apache.flink.kubernetes.configuration.KubernetesConfigOptions; +import org.apache.flink.kubernetes.utils.KubernetesUtils; +import org.apache.flink.runtime.clusterframework.ContaineredTaskManagerParameters; +import org.apache.flink.util.TestLogger; + +import org.junit.Test; + +import java.util.HashMap; + +import static org.junit.Assert.assertEquals; + +/** + * Tests for {@link KubernetesUtils}. + */ +public class KubernetesUtilsTest extends TestLogger { + + final String confDirInPod = "/opt/flink/conf"; + final String logDirInPod = "/opt/flink/log"; + + @Test + public void testGetJobManagerShellCommand() { + final Configuration cfg = new Configuration(); + + final String java = "$JAVA_HOME/bin/java"; + final String classpath = "-classpath $FLINK_CLASSPATH"; + final String jvmmem = "-Xms768m -Xmx768m"; + final String jvmOpts = "-Djvm"; // if set + final String jmJvmOpts = "-DjmJvm"; // if set + final String logfile = String.format("-Dlog.file=%s/jobmanager.log", logDirInPod); + final String logback = String.format("-Dlogback.configurationFile=file:%s/logback.xml", confDirInPod); + final String log4j = String.format("-Dlog4j.configuration=file:%s/log4j.properties", confDirInPod); + final String mainClass = "org.apache.flink.kubernetes.KubernetesUtilsTest"; + final String mainClassArgs = "--job-id=1 -Dtest.key=value"; + final String redirects = String.format("1> %s/jobmanager.out 2> %s/jobmanager.err", logDirInPod, logDirInPod); + + int jobManagerMem = 768; + assertEquals( + java + " " + classpath + " " + jvmmem + Review comment: Can we extract the command building into a common method and only leave the varying fields as parameters? Then we can also have fewer variable definitions above. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
