zhuzhurk commented on a change in pull request #9965: [FLINK-10935][kubernetes]Implement KubeClient with Faric8 Kubernetes clients URL: https://github.com/apache/flink/pull/9965#discussion_r353007013
########## File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesTestBase.java ########## @@ -0,0 +1,193 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes; + +import org.apache.flink.configuration.ConfigConstants; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.kubernetes.configuration.KubernetesConfigOptions; +import org.apache.flink.kubernetes.configuration.KubernetesConfigOptionsInternal; +import org.apache.flink.kubernetes.kubeclient.Fabric8FlinkKubeClient; +import org.apache.flink.kubernetes.kubeclient.FlinkKubeClient; +import org.apache.flink.kubernetes.kubeclient.decorators.Decorator; +import org.apache.flink.kubernetes.kubeclient.decorators.InitializerDecorator; +import org.apache.flink.kubernetes.kubeclient.decorators.OwnerReferenceDecorator; +import org.apache.flink.kubernetes.kubeclient.decorators.ServiceDecorator; +import org.apache.flink.kubernetes.kubeclient.resources.KubernetesService; +import org.apache.flink.kubernetes.utils.Constants; +import org.apache.flink.runtime.clusterframework.BootstrapTools; +import org.apache.flink.test.util.TestBaseUtils; +import org.apache.flink.util.TestLogger; + +import io.fabric8.kubernetes.api.model.LoadBalancerIngress; +import io.fabric8.kubernetes.api.model.LoadBalancerStatus; +import io.fabric8.kubernetes.api.model.Service; +import io.fabric8.kubernetes.api.model.ServiceStatusBuilder; +import io.fabric8.kubernetes.api.model.WatchEvent; +import io.fabric8.kubernetes.client.KubernetesClient; +import org.junit.Before; +import org.junit.Rule; +import org.junit.rules.TemporaryFolder; + +import java.io.File; +import java.io.IOException; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +/** + * Base test class for Kubernetes. + */ +public class KubernetesTestBase extends TestLogger { + @Rule + public MixedKubernetesServer server = new MixedKubernetesServer(true, true); + + @Rule + public TemporaryFolder temporaryFolder = new TemporaryFolder(); + + private File flinkConfDir; + + protected final String nameSpace = "test"; Review comment: I did no see a concise on this. https://stackoverflow.com/questions/24289070/why-we-should-not-use-protected-static-in-java I can also find lots of `protected static final` in Flink code. Flink checkstyle is not against it. To me, static is always better when possible. And you can decide. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
