shuttie commented on issue #10358: [FLINK-14346] [serialization] faster implementation of StringValue writeString and readString URL: https://github.com/apache/flink/pull/10358#issuecomment-561196350 For deserialization, allocating a small buffer is not that much a significant overhead, so the fallback is not really needed: ``` [info] Benchmark (length) (stringType) Mode Cnt Score Error Units [info] StringDeserializerBenchmark.deserializeDefault 1 ascii avgt 5 46.588 ± 4.684 ns/op [info] StringDeserializerBenchmark.deserializeDefault 2 ascii avgt 5 58.620 ± 3.946 ns/op [info] StringDeserializerBenchmark.deserializeDefault 3 ascii avgt 5 77.313 ± 10.427 ns/op [info] StringDeserializerBenchmark.deserializeDefault 4 ascii avgt 5 90.241 ± 10.840 ns/op [info] StringDeserializerBenchmark.deserializeDefault 5 ascii avgt 5 102.410 ± 13.860 ns/op [info] StringDeserializerBenchmark.deserializeDefault 6 ascii avgt 5 120.779 ± 14.496 ns/op [info] StringDeserializerBenchmark.deserializeDefault 7 ascii avgt 5 131.607 ± 14.304 ns/op [info] StringDeserializerBenchmark.deserializeImproved 1 ascii avgt 5 51.051 ± 3.370 ns/op [info] StringDeserializerBenchmark.deserializeImproved 2 ascii avgt 5 51.510 ± 3.727 ns/op [info] StringDeserializerBenchmark.deserializeImproved 3 ascii avgt 5 51.531 ± 5.641 ns/op [info] StringDeserializerBenchmark.deserializeImproved 4 ascii avgt 5 51.571 ± 8.137 ns/op [info] StringDeserializerBenchmark.deserializeImproved 5 ascii avgt 5 52.366 ± 5.513 ns/op [info] StringDeserializerBenchmark.deserializeImproved 6 ascii avgt 5 56.548 ± 7.410 ns/op [info] StringDeserializerBenchmark.deserializeImproved 7 ascii avgt 5 52.861 ± 7.447 ns/op ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
