xintongsong commented on a change in pull request #10397:
[FLINK-15023][core][runtime] Remove on-heap managed memory
URL: https://github.com/apache/flink/pull/10397#discussion_r353283660
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
##########
@@ -681,20 +677,16 @@ public void
testManagedMemoryFractionForSpecifiedResourceSpec() throws Exception
final StreamConfig sourceConfig = new
StreamConfig(vertex1.getConfiguration());
assertEquals(0.1,
sourceConfig.getManagedMemoryFractionOnHeap(), 0.000001);
- assertEquals(0.4,
sourceConfig.getManagedMemoryFractionOffHeap(), 0.000001);
Review comment:
But I think I should remove validation for on-heap and keep it for off-heap,
since this commit is removing on-heap and make managed memory all off-heap. The
setting up part as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
