zhuzhurk commented on a change in pull request #10406: [FLINK-15045][runtime] 
Only log RestartStrategy in legacy scheduling mode
URL: https://github.com/apache/flink/pull/10406#discussion_r353527694
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultSchedulerFactory.java
 ##########
 @@ -69,14 +72,15 @@ public SchedulerNG createInstance(
 
                final SchedulingStrategyFactory schedulingStrategyFactory = 
createSchedulingStrategyFactory(jobGraph.getScheduleMode());
 
 Review comment:
   Here's a question unrelated to this issue.
   Could we make the logging level for schedulingStrategy in 
`DefaultScheduler#startSchedulingInternal` to be `info`?
   I did not find a way to identify the scheduling strategy from info level 
logs, without it we may need to ask users for this info.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to