zhuzhurk commented on a change in pull request #10406: [FLINK-15045][runtime]
Only log RestartStrategy in legacy scheduling mode
URL: https://github.com/apache/flink/pull/10406#discussion_r353600708
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/RestartBackoffTimeStrategyFactoryLoader.java
##########
@@ -56,20 +56,20 @@ private RestartBackoffTimeStrategyFactoryLoader() {
*
* @param jobRestartStrategyConfiguration restart configuration given
within the job graph
* @param clusterConfiguration cluster(server-side) configuration
- * @param isCheckpointingEnabled if checkpointing is enabled for the job
+ * @param checkpointingEnabled if checkpointing is enabled for the job
* @return new version restart strategy factory
*/
public static RestartBackoffTimeStrategy.Factory
createRestartBackoffTimeStrategyFactory(
final RestartStrategies.RestartStrategyConfiguration
jobRestartStrategyConfiguration,
final Configuration clusterConfiguration,
- final boolean isCheckpointingEnabled) {
+ final boolean checkpointingEnabled) {
Review comment:
Ok. Seems to me it is mostly referring to class fields' name regarding the
getter/setter name.
As a variable, I think both the previous and current one are fine since they
make sense and do not look weird.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
