TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to execution environments URL: https://github.com/apache/flink/pull/10408#issuecomment-561510624 > > Another question is about failure. Currently we only call back on submission/execution succeed. If we want to react on failure also, the interface should be changed into `onJobSubmitted(JobClient, Throwable)` like `whenComplete(R, Throwable)`. > > Why `onJobExecuted` is only called when execution succeed ? I think flink catch the exception when flink job fails, so ideally we should be able to call `onJobExecuted` even when the job is failed. Yes it is no more than a decision. We can implement `onJobExecuted` as `onJobExecuted(JobExecutionResult, Throwable)` or `onJobExecuted(Either<JobExecutionResult, Throwable>)`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
