TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to 
execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-561541292
 
 
   @aljoscha it would make sense. One concern is about the close actions. For 
some implementations of JobClient, specifically, anon subclasses of 
ClusterClientJobClientAdapter, we close some internal resource such as the 
MiniCluster or remove a shutdown hook. It should not be the case for that 
duplicated one. The duplicated one should only close , for our specific 
implementation, rest client & ha services & execution service held by 
ClusterClient.
   
   I have an idea for doing so, let me push a follow-up commit and give you an 
impression.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to