JingsongLi commented on a change in pull request #10399:
[FLINK-14959][table-planner-blink] Support precision of LocalZonedTimestampType
in blink planner
URL: https://github.com/apache/flink/pull/10399#discussion_r353576451
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/LongHashJoinGenerator.scala
##########
@@ -49,10 +49,13 @@ object LongHashJoinGenerator {
keyType.getFieldCount == 1 && {
keyType.getTypeAt(0).getTypeRoot match {
case BIGINT | INTEGER | SMALLINT | TINYINT | FLOAT | DOUBLE | DATE |
- TIME_WITHOUT_TIME_ZONE | TIMESTAMP_WITH_LOCAL_TIME_ZONE => true
+ TIME_WITHOUT_TIME_ZONE => true
case TIMESTAMP_WITHOUT_TIME_ZONE =>
val timestampType = keyType.getTypeAt(0).asInstanceOf[TimestampType]
if (SqlTimestamp.isCompact(timestampType.getPrecision)) true else
false
+ case TIMESTAMP_WITH_LOCAL_TIME_ZONE =>
+ val lzTs = keyType.getTypeAt(0).asInstanceOf[LocalZonedTimestampType]
+ if (SqlTimestamp.isCompact(lzTs.getPrecision)) true else false
Review comment:
please use `SqlTimestamp.isCompact(lzTs.getPrecision)` directly, please
modify `TIMESTAMP_WITHOUT_TIME_ZONE` too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
