danny0405 commented on a change in pull request #10400:
[FLINK-13195][sql-client] Add create table support for SqlClient
URL: https://github.com/apache/flink/pull/10400#discussion_r353587142
##########
File path:
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java
##########
@@ -614,6 +614,67 @@ public void testParameterizedTypes() throws Exception {
executor.closeSession(sessionId);
}
+ @Test
+ public void testCreateTable() throws Exception {
+ final Executor executor = createDefaultExecutor(clusterClient);
+ final SessionContext session = new
SessionContext("test-session", new Environment());
+ String sessionId = executor.openSession(session);
+ try {
+ executor.useCatalog(sessionId, "catalog1");
Review comment:
We also need tests:
1. create table with full qualified name `create table catalog1.db1.table1
(...) with (...)`
2. create table with only database name and table name `create table
db1.table1 (...) with (...)`
3. create table with computed column
4. create table with watermark definition
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
