danny0405 commented on a change in pull request #10400:
[FLINK-13195][sql-client] Add create table support for SqlClient
URL: https://github.com/apache/flink/pull/10400#discussion_r353582013
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
##########
@@ -525,6 +528,16 @@ private boolean callInsertInto(SqlCommandCall cmdCall) {
return true;
}
+ private void callCreateTable(SqlCommandCall cmdCall) {
+ try {
+ executor.createTable(sessionId, cmdCall.operands[0]);
+ } catch (SqlExecutionException e) {
+ printExecutionException(e);
+ return;
Review comment:
We may need to invoke `executor.dropTable` for roll back once the `drop
table` command is supported. Or do you plan to support drop table in this PR ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
