KurtYoung commented on a change in pull request #10399:
[FLINK-14959][table-planner-blink] Support precision of LocalZonedTimestampType
in blink planner
URL: https://github.com/apache/flink/pull/10399#discussion_r353571650
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/calcite/FlinkTypeFactory.scala
##########
@@ -76,7 +76,8 @@ class FlinkTypeFactory(typeSystem: RelDataTypeSystem)
extends JavaTypeFactoryImp
case LogicalTypeRoot.DATE => createSqlType(DATE)
case LogicalTypeRoot.TIME_WITHOUT_TIME_ZONE => createSqlType(TIME)
case LogicalTypeRoot.TIMESTAMP_WITH_LOCAL_TIME_ZONE =>
- createSqlType(TIMESTAMP_WITH_LOCAL_TIME_ZONE)
+ val lzTs = t.asInstanceOf[LocalZonedTimestampType]
Review comment:
I noticed line 130:
> Kind in TimestampType do not affect the hashcode and equals, So we can't
put it to seenTypes
So why `TIMESTAMP_WITH_LOCAL_TIME_ZONE` is not handled there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
