shuttie commented on a change in pull request #10358: [FLINK-14346] 
[serialization] faster implementation of StringValue writeString and readString
URL: https://github.com/apache/flink/pull/10358#discussion_r353618383
 
 

 ##########
 File path: 
flink-core/src/test/java/org/apache/flink/types/StringSerializationTest.java
 ##########
 @@ -56,6 +56,27 @@ public void testNonNullValues() {
                        fail("Exception in test: " + e.getMessage());
                }
        }
+
+       @Test
+       public void testUnicodeValues() {
+               try {
 
 Review comment:
   I just did it in the way it's done with other string serialization tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to