GJL commented on a change in pull request #10406: [FLINK-15045][runtime] Only
log RestartStrategy in legacy scheduling mode
URL: https://github.com/apache/flink/pull/10406#discussion_r353620416
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/RestartBackoffTimeStrategyFactoryLoader.java
##########
@@ -56,20 +56,20 @@ private RestartBackoffTimeStrategyFactoryLoader() {
*
* @param jobRestartStrategyConfiguration restart configuration given
within the job graph
* @param clusterConfiguration cluster(server-side) configuration
- * @param isCheckpointingEnabled if checkpointing is enabled for the job
+ * @param checkpointingEnabled if checkpointing is enabled for the job
* @return new version restart strategy factory
*/
public static RestartBackoffTimeStrategy.Factory
createRestartBackoffTimeStrategyFactory(
final RestartStrategies.RestartStrategyConfiguration
jobRestartStrategyConfiguration,
final Configuration clusterConfiguration,
- final boolean isCheckpointingEnabled) {
+ final boolean checkpointingEnabled) {
Review comment:
For consistency I would prefer having the same naming conventions for
boolean setters and static methods. However, since there is no guideline in the
coding style, and we are already using both styles [1][2], I'd be also fine to
drop this commit.
[1]
https://github.com/apache/flink/blob/86c232437f74576fdee3baad11c58f77714269fc/flink-core/src/main/java/org/apache/flink/core/fs/EntropyInjector.java#L112
[2]
https://github.com/apache/flink/blob/86c232437f74576fdee3baad11c58f77714269fc/flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowSerializationSchema.java#L206
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
