GJL commented on a change in pull request #10406: [FLINK-15045][runtime] Only
log RestartStrategy in legacy scheduling mode
URL: https://github.com/apache/flink/pull/10406#discussion_r353648524
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultSchedulerFactory.java
##########
@@ -49,6 +50,8 @@
*/
public class DefaultSchedulerFactory implements SchedulerNGFactory {
+ private static final Logger LOG =
LoggerFactory.getLogger(DefaultSchedulerFactory.class);
+
@Override
public SchedulerNG createInstance(
final Logger log,
Review comment:
> Actually I'm also thinking which is better:
>
> 1. use `JobManager` logger for `DefaultScheduler` as we currently do,
or
>
> 2. create an individual logger for `DefaultScheduler`
>
>
> WDYT?
At the moment, we use `JobManager` logger only for historical reasons, i.e.,
I did not want to change behavior. If we use static loggers per class, it would
be easier to recognize which scheduler is used, and it would be slightly easier
to find the line where a given log message is issued. However, I don't see
immediate call of action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
