JingsongLi commented on a change in pull request #10403: [FLINK-14645][table]
Support to keep nullability and precision when converting DataTypes to
properties
URL: https://github.com/apache/flink/pull/10403#discussion_r353638111
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/utils/LegacyTypeInfoDataTypeConverter.java
##########
@@ -216,6 +216,18 @@ else if (canConvertToTimestampTypeInfoLenient(dataType)) {
return Types.SQL_TIMESTAMP;
}
+ // relax the precision constraint as LocalDateTime can store
the highest precision
+ else if (hasRoot(logicalType,
LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE) &&
Review comment:
Maybe you can take a look to above, there are some comments and limitation
for `java.sql.Timestamp`.
And others... If you want to modify, maybe you should modify all or just
respect their rules. (Like in `canConvertToTimestampTypeInfoLenient`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
