zentol commented on a change in pull request #10359: [FLINK-14813][metrics]
Provide `isBackPressured` Task metric
URL: https://github.com/apache/flink/pull/10359#discussion_r353671298
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -351,6 +353,7 @@ public Task(
this.taskManagerConfig =
Preconditions.checkNotNull(taskManagerConfig);
this.metrics = metricGroup;
+ metricGroup.gauge(MetricNames.IS_BACKPRESSURED, new
BackPressureGauge(this));
Review comment:
> Under what circumstances would call isBackpressured without the
constructor having finished？
@jinglining The moment `gauge()` returns the metric is accessible for the
metric system, and may call it before the rest of the constructor has run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
