danny0405 commented on a change in pull request #10388: [FLINK-14912][Table]
create, drop catalog functions through catalog manager
URL: https://github.com/apache/flink/pull/10388#discussion_r353723113
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/operations/SqlToOperationConverter.java
##########
@@ -179,6 +195,72 @@ private Operation convertDropTable(SqlDropTable
sqlDropTable) {
return new DropTableOperation(identifier,
sqlDropTable.getIfExists());
}
+ /** Convert CREATE FUNCTION statement. */
+ private Operation convertCreateFunction(SqlCreateFunction
sqlCreateFunction) {
+ FunctionLanguage language =
parseLanguage(sqlCreateFunction.getFunctionLanguage());
+ CatalogFunction catalogFunction = new CatalogFunctionImpl(
+ sqlCreateFunction.getFunctionClassName().toValue(),
language);
+
Review comment:
We better use `SqlLiteral.getValueAs` instead of `SqlLiteral.toValue`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
