StephanEwen commented on a change in pull request #10329:
[FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of
unmanaged memory
URL: https://github.com/apache/flink/pull/10329#discussion_r353871656
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
##########
@@ -244,6 +252,8 @@ public RocksDBKeyedStateBackend(
this.kvStateInformation = kvStateInformation;
this.writeOptions = new WriteOptions().setDisableWAL(true);
+ checkArgument(writeBatchSize >= 0, "Write batch size have to be
no negative value.");
Review comment:
For whether to use `checkArgument` and `checkNotNull` I would use the
following heuristic: Use it when you "enter" an API or set of public classes.
After arguments have been checked once, or when they are only passed between
tighly collaborating classes (non public, same package) you usually don't check
again.
Side note: I think we agreed in the code style to not use `@Nonnull` because
that is assumed the default, and only use `@Nullable` when something is
actually nullable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
