StephanEwen commented on a change in pull request #10329:
[FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of
unmanaged memory
URL: https://github.com/apache/flink/pull/10329#discussion_r353679918
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
##########
@@ -244,6 +252,8 @@ public RocksDBKeyedStateBackend(
this.kvStateInformation = kvStateInformation;
this.writeOptions = new WriteOptions().setDisableWAL(true);
+ checkArgument(writeBatchSize >= 0, "Write batch size have to be
no negative value.");
Review comment:
I think the annotation is only really evaluated in IntelliJ by the
inspections. It does not prevent anything during runtime, so this extra check
does not hurt, in my opinion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
