godfreyhe commented on a change in pull request #10316:
[FLINK-14624][table-blink] Support computed column as rowtime attribute
URL: https://github.com/apache/flink/pull/10316#discussion_r354075285
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamExecWatermarkAssigner.scala
##########
@@ -20,20 +20,21 @@ package
org.apache.flink.table.planner.plan.nodes.physical.stream
import org.apache.flink.api.dag.Transformation
import org.apache.flink.streaming.api.transformations.OneInputTransformation
-import org.apache.flink.table.api.TableException
import org.apache.flink.table.api.config.ExecutionConfigOptions
import org.apache.flink.table.dataformat.BaseRow
-import org.apache.flink.table.planner.calcite.{FlinkContext, FlinkTypeFactory}
+import org.apache.flink.table.planner.calcite.FlinkTypeFactory
+import org.apache.flink.table.planner.codegen.WatermarkGeneratorCodeGenerator
import org.apache.flink.table.planner.delegation.StreamPlanner
import org.apache.flink.table.planner.plan.`trait`.{MiniBatchIntervalTraitDef,
MiniBatchMode}
import org.apache.flink.table.planner.plan.nodes.calcite.WatermarkAssigner
import org.apache.flink.table.planner.plan.nodes.exec.{ExecNode,
StreamExecNode}
import
org.apache.flink.table.planner.utils.TableConfigUtils.getMillisecondFromConfigDuration
-import
org.apache.flink.table.runtime.operators.wmassigners.{BoundedOutOfOrderWatermarkGenerator,
MiniBatchAssignerOperator, MiniBatchedWatermarkAssignerOperator,
WatermarkAssignerOperator}
+import
org.apache.flink.table.runtime.operators.wmassigners.{MiniBatchedWatermarkAssignerOperatorFactory,
WatermarkAssignerOperatorFactory}
import org.apache.flink.table.runtime.typeutils.BaseRowTypeInfo
-import org.apache.flink.util.Preconditions
import org.apache.calcite.plan.{RelOptCluster, RelTraitSet}
import org.apache.calcite.rel.{RelNode, RelWriter}
+import org.apache.calcite.rex.RexNode
+import
org.apache.flink.table.planner.plan.utils.RelExplainUtil.preferExpressionFormat
Review comment:
nit: move this line close to `org.apache.flink.table.xxx`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
