wuchong commented on issue #10316: [FLINK-14624][table-blink] Support computed column as rowtime attribute URL: https://github.com/apache/flink/pull/10316#issuecomment-561943912 Hi @godfreyhe , actually, the `StreamExecWatermarkAssigner` is responsible for (maybe minibatch-ed) watermark assigner on **rowtime**. So one is emitting minibatch event (we use watermark to represent it), the another one is emitting watermark event. The reason to merge minibatch-ed event-time watermark assigner into `StreamExecWatermarkAssigner` is that it is still a watermark assigner, it only adjust the emit interval, no semantic changes to non-minibatched watermark assginer. If we merge it into `StreamExecMiniBatchAssigner`, the `StreamExecMiniBatchAssigner` will change the RowType which changes the semantic, and we will have more duplicate code in it (like code generate watermark emitter).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
