Github user ChengXiangLi commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1255#discussion_r43991097
  
    --- Diff: 
flink-java/src/main/java/org/apache/flink/api/java/operators/PartitionOperator.java
 ---
    @@ -148,9 +147,6 @@ else if (pKeys instanceof Keys.SelectorFunctionKeys) {
                        }
                        
                } 
    -           else if (pMethod == PartitionMethod.RANGE) {
    --- End diff --
    
    Should we check this in some else place? I mean it's more like a sort 
issue, not a range partitioner issue. If  `pKeys.getKeyType().isSortKeyType() 
== false` and not fully sort, user just want to balance skew data through range 
partitioner shuffle, we should support it, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to