Github user ChengXiangLi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1255#discussion_r43986746
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/PartitionOperator.java
---
@@ -148,9 +147,6 @@ else if (pKeys instanceof Keys.SelectorFunctionKeys) {
}
}
- else if (pMethod == PartitionMethod.RANGE) {
--- End diff --
Do you mean that if `pKeys.getKeyType().isSortKeyType() == false` and it's
range partitioner, we should throw a exception?
If yes, I think it should be ok, for the range partitioner, it does not
require the range to be sorted in meaningful way, it just try to make each
target partition have roughly same size data. As long as we can compare key
fields, we should be able to use range partitioner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
