hequn8128 commented on a change in pull request #10086: [FLINK-14584][python]
Support complex data types in Python user-defined functions
URL: https://github.com/apache/flink/pull/10086#discussion_r354182465
##########
File path:
flink-python/src/main/java/org/apache/flink/table/runtime/typeutils/PythonTypeUtils.java
##########
@@ -70,6 +89,43 @@ public static TypeSerializer
toBlinkTypeSerializer(LogicalType logicalType) {
return logicalType.accept(new
LogicalTypeToProtoTypeConverter());
}
+ /**
+ * Convert LogicalType to conversion class.
Review comment:
This class is only used for flink planner. Maybe change the comment to:
"Convert LogicalType to conversion class for flink planner"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
