hequn8128 commented on a change in pull request #10086: [FLINK-14584][python] 
Support complex data types in Python user-defined functions
URL: https://github.com/apache/flink/pull/10086#discussion_r354141092
 
 

 ##########
 File path: flink-python/pyflink/table/tests/test_udf.py
 ##########
 @@ -319,6 +319,30 @@ def date_func(date_param):
                 'date_param is wrong value %s !' % date_param
             return date_param
 
+        def array_func(array_param):
+            assert array_param == [1, 2, 3], \
+                'array_param is wrong value %s !' % array_param
+            return array_param
+
+        def map_func(map_param):
+            assert map_param == {1: 'flink', 2: 'pyflink'}, \
+                'map_param is wrong value %s !' % map_param
+            return map_param
+
+        def multiset_func(multiset_param):
+            assert multiset_param == [1, 1, 2], \
+                'multiset_param is wrong value %s !' % multiset_param
+            return multiset_param
+
+        def create_multiset_func():
 
 Review comment:
   It's not good to use udf to create input data. Because, the data will be 
given to `multiset_func` directly within Python, i.e., the serialize method of 
the java serializer can not be tested.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to