zhijiangW commented on a change in pull request #10375: [FLINK-14845][runtime] 
Introduce data compression to reduce disk and network IO of shuffle.
URL: https://github.com/apache/flink/pull/10375#discussion_r354720671
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/BoundedBlockingSubpartitionWriteReadTest.java
 ##########
 @@ -216,12 +236,13 @@ private BoundedBlockingSubpartition createSubpartition() 
throws IOException {
                        BoundedBlockingSubpartition subpartition,
                        int numReaders,
                        int numLongs,
-                       int numBuffers) throws IOException {
+                       int numBuffers,
+                       boolean compressEnabled) throws IOException {
 
 Review comment:
   are there any issues to make it static?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to