zhijiangW commented on a change in pull request #10375: [FLINK-14845][runtime]
Introduce data compression to reduce disk and network IO of shuffle.
URL: https://github.com/apache/flink/pull/10375#discussion_r354791462
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGate.java
##########
@@ -80,13 +80,17 @@
/**
* Blocking call waiting for next {@link BufferOrEvent}.
*
+ * <p>Note: It should be guaranteed that the previous returned buffer
has been recycled before getting next one.
Review comment:
It is better to add some explanations here.
.....next one, because the {@link BufferDecompressor} reuses the same
intermediate buffer for storing the decompressed data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
