zhuzhurk opened a new pull request #10462: [FLINK-15031][runtime] Calculate required shuffle memory before allocating slots if resources are specified URL: https://github.com/apache/flink/pull/10462 ## What is the purpose of the change Minimum network buffers are required by tasks to work. Currently a task is possible to be deployed to a TM with insufficient network buffers, and fails on launching. To avoid that, we should calculate required network memory for a task/SlotSharingGroup before allocating a slot for it. ## Brief change log - *Introduce ShuffleMaster#getShuffleMemoryForTask interface and implement it in NettyShuffleMaster* - *Introduce ResourceRequirementsRetriever to retrieve vertex/group resource requirements* - *Leverage ResourceRequirementsRetriever to retrieve proper resource requirements for slot allocation* ## Verifying this change This change added tests and can be verified as follows: - *unit tests are added for NettyShuffleMaster#getShuffleMemoryForTask* - *unit tests are added for ResourceRequirementsRetriever* - *unit tests are added for ExecutionVertexSchedulingRequirementsMapper to verify the usages of ResourceRequirementsRetriever* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
