Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-154428753
There are still two issues I noticed. Printing to standard out should be
disabled during the dry-run phase. Just like in the OptimizerPlanEnvironment.
The other one is ContextEnvironment. Do you think you could refactor your
changes in ContextEnvironment into a separate DetachedEnvironment? We don't
really need the context for the dry run. Thus, we have a better separation of
concerns with an extra class for the detached execution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---